search

spacetelescope / stpipe

https://stpipe.readthedocs.io
Other
3 stars 25 forks source link

del model in map_function #181

Closed braingram closed 1 month ago

braingram commented 1 month ago

This PR makes a minor change to AbstractModelLibrary.map_function to reduce memory usage. More details can be found in the issue but the tldr is that this prevents having 2x models in memory during map_function.

Fixes: https://github.com/spacetelescope/stpipe/issues/173

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 73.29%. Comparing base (b66eb3f) to head (5efae61). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #181 +/- ## ========================================== + Coverage 73.27% 73.29% +0.01% ========================================== Files 25 25 Lines 1916 1917 +1 ========================================== + Hits 1404 1405 +1 Misses 512 512 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

braingram commented 1 month ago

Thanks! The romancal failure is due to the unrelated background schema changes.