search

spacetelescope / style-guides

An opinionated guide on how we work.
Creative Commons Attribution 4.0 International
55 stars 33 forks source link

Release guide #72

Closed nden closed 5 years ago

nden commented 5 years ago

Close #12. @stscicrawford I feel this is too much detail for a style guide. OTH I included details which confused me initially so I thought they may be useful to others. Comments welcome.

arfon commented 5 years ago

This looks pretty good to me @nden. I made a few stylistic recommendations and fixed some typos.

nden commented 5 years ago

@pllim Is it too much to ask for line breaks every 80 char so this document is easier on the eyes in its unrendered form?

Yes, but I'll see what I can do.

nden commented 5 years ago

@arfon @pllim Thanks for reviewing! I think I've addressed all comments so far.

pllim commented 5 years ago

While I did suggest removing conda-dev, I wonder if we should mention astroconda (not the dev).

stscicrawford commented 5 years ago

Overall looks good! I think having a short section on astroconda and how and when to include your STScI package in astroconda would be helpful.

Thoughts @jhunkeler ?

Edited: Will open this as a separate issue and merge as is.