spacetelescope / style-guides

An opinionated guide on how we work.
Creative Commons Attribution 4.0 International
55 stars 33 forks source link

Updated text on dependency versions #79

Closed brechmos-stsci closed 5 years ago

brechmos-stsci commented 5 years ago

Had a long conversation with @eteq regarding "pinning" of dependencies and there were several assumptions and nuances that were discussed that I wanted to incorporate in the text. My take away was:

Hopefully the text encompasses these thoughts.

SaOgaz commented 5 years ago

Adding note here after some in person discussion with @brechmos-stsci, sometimes we hit version limitations (caps on how high of a version we can access) in our astroconda channel because continuum hasn't updated to the latest version yet (i'm I remembering this right @jhunkeler?), so we will need to factor that in as well.

brechmos-stsci commented 5 years ago

bump @eteq @stscicrawford Is there anything else you would modified here, or is it good to merge now?

eteq commented 5 years ago

I think everything except the one bit above is all good. So if you are happy with my suggestion there I think it's good to go once implemented, @brechmos-stsci. So I'll approve this so as not to block merging if that change is made.