spacetelescope / synphot_refactor

Synthetic photometry using Astropy
http://synphot.readthedocs.io/en/latest/
BSD 3-Clause "New" or "Revised" License
38 stars 25 forks source link

MNT: NumPy 2.0 compatibility, other fixes #363

Closed pllim closed 1 year ago

pllim commented 1 year ago

Description

This pull request is to fix #362 and any resulting modernization that has to happen.

github-actions[bot] commented 1 year ago

Thank you for your contribution! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

github-actions[bot] commented 1 year ago

👋 Thank you for your draft pull request! Do you know that you can use [ci skip] or [skip ci] in your commit messages to skip running continuous integration tests until you are ready?

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage is 100.00% of modified lines.

Files Changed Coverage
synphot/observation.py 100.00%
synphot/spectrum.py 100.00%

:loudspeaker: Thoughts on this report? Let us know!.

pllim commented 1 year ago

Only 95 failures with numpy 2.0.dev 😭

pllim commented 1 year ago

Phew... Not too bad.

pllim commented 1 year ago

I cannot fix stsynphot easily without merging this, so just gonna merge...