TST: Fix devdeps - Githubissues

spacetelescope / synphot_refactor

Synthetic photometry using Astropy

http://synphot.readthedocs.io/en/latest/

BSD 3-Clause "New" or "Revised" License

39 stars 25 forks source link

TST: Fix devdeps #368

Closed pllim closed 11 months ago

pllim commented 11 months ago

Description

This pull request is to fix devdeps job failure.

xref https://github.com/astropy/astropy/issues/15638

github-actions[bot] commented 11 months ago

Thank you for your contribution! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

[ ] Do the proposed changes actually accomplish desired goals?
[ ] Do the proposed changes follow the STScI coding guidelines?
[ ] Are tests added/updated as required? If so, do they follow the STScI testing guidelines?
[ ] Are docs added/updated as required?
[ ] Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions.
[ ] Did the CI pass? If no, are the failures related?
[ ] Is a change log needed?
[ ] Is a milestone set? Milestone must be set but we cannot check for it on Actions; do not let the green checkmark fool you.

github-actions[bot] commented 11 months ago

👋 Thank you for your draft pull request! Do you know that you can use [ci skip] or [skip ci] in your commit messages to skip running continuous integration tests until you are ready?

codecov[bot] commented 11 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (7eaa3dc) 96.80% compared to head (d9a9a03) 96.80%.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #368 +/- ## ======================================= Coverage 96.80% 96.80% ======================================= Files 17 17 Lines 2034 2034 ======================================= Hits 1969 1969 Misses 65 65 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

pllim commented 11 months ago

Tsk tsk, need to build C-extension with unreleased numpy.

pllim commented 11 months ago

The devdeps log still makes no sense to me but somehow the failure went away. I'll call this a win and move on.

.pkg: freeze> python -m pip freeze --all
.pkg: numpy==1.26.2,packaging==23.2,pip==23.3.1,setuptools==69.0.2,setuptools-scm==8.0.4,typing_extensions==4.8.0,wheel==0.41.3