search

spacetelescope / ullyses

Code to create products for the ULLYSES program
https://ullyses.stsci.edu/
BSD 3-Clause "New" or "Revised" License
2 stars 6 forks source link

move build metadata into pyproject.toml #46

Closed zacharyburnett closed 9 months ago

zacharyburnett commented 1 year ago

align with PEP621 metadata standards and setuptools>=61.2 build with PEP517

zacharyburnett commented 1 year ago

failing tests seem to be the same as on the main branch: https://github.com/spacetelescope/ullyses/actions/runs/4359794031/jobs/7621979281#step:5:1089

def http_error_default(self, req, fp, code, msg, hdrs):
>       raise HTTPError(req.full_url, code, msg, hdrs, fp)
E       urllib.error.HTTPError: HTTP Error 404: Not Found
tapastro commented 9 months ago

Outdated PR, work done in #78.

tapastro commented 9 months ago

Actually, there were some updates here to the testing workflow that may be useful? I may have been hasty in closing this.

zacharyburnett commented 9 months ago

Outdated PR, work done in #78.

Great! I did notice however that the runtime dependencies require setuptools: https://github.com/spacetelescope/ullyses/blob/6f5d101b046802b9961f80a2d748327cebdf0d2d/pyproject.toml#L25 but I can't find any usages of setuptools in the code itself; is that included by error? https://github.com/search?q=repo%3Aspacetelescope%2Fullyses+setuptools&type=code

tapastro commented 9 months ago

Very much likely - I guess the build-requires section gets setuptools for pyproject installs, but it isn't required to be listed in the dependency list, as the package itself doesn't need it?