spacetelescope / ullyses

Code to create products for the ULLYSES program
https://ullyses.stsci.edu/
BSD 3-Clause "New" or "Revised" License
2 stars 6 forks source link

Add fix for HASP data sometimes creating a product with no good pixels #47

Closed stscirij closed 1 year ago

stscirij commented 1 year ago

When the coadd code creates a product with no good pixels (all have effective_exptime = 0.0), the code will throw an exception when trying to calculate the first and last good wavelengths. This sometimes happens for HASP STIS data, but not for Ullyses data as the preprocessing of STIS data takes care of this. To fix, the first and last good wavelengths are set to None if there are no good pixels. The HASP wrapper code detects this and doesn't try to make a product in such a case, but I didn't add a handler to the Ullyses wrapper since the case doesn't occur (and perhaps throwing an exception is preferred to raise visibility to this case).