search

spacetelescope / ullyses

Code to create products for the ULLYSES program
https://ullyses.stsci.edu/
BSD 3-Clause "New" or "Revised" License
2 stars 6 forks source link

Fix problem with output data overflowing output array #60

Closed stscirij closed 1 year ago

stscirij commented 1 year ago

This is the same fix that was applied to STIS CCD data in #47. I didn't expect it to be a problem for COS data, but we have seen some NUV data overflow the output array and this small change fixes the problem

stscirij commented 1 year ago

This will result in one extra element at the long-wavelength end of each of the arrays, but all the other elements should be identical to those generated without this fix

jotaylor commented 1 year ago

@stscirij Curiously, I obtained identical results when I compared products from this branch with main. I used target AV-14 which has G185M data. Is that expected? I was expecting the data arrays to be one element longer.

jotaylor commented 1 year ago

Oops, disregard my previous comment. I don't think I properly checked out this branch when making the comparison products. Now I see the addition of another element in the data arrays. Otherwise the spectra appear identical.