We only used the new HASP abut strategy for level 4 (preview-spec) products. We neglected to use it also for level 3 (aspec). Because of this, aspecs were being created in the same method as previous DRs. The gratings that contribute to each aspec were hardcoded, because they are grouped by resolution. However, as we added more non-ULLYSES data (i.e. AR data), we did not update this hardcoded list. This led to some AR modes not being included in aspecs.
There were two solutions. 1) Simply add the missing gratings to the hardcoded list. This does not address the issues that level 3 products are using the old abut strategy.
2) Add missing gratings to hardcoded list AND use new abut strategy. This is what I did. *Note that I also followed the currently implemented logic which is to NOT make an aspec when only 1 mode exists for a resolution grouping. I checked with ULLYSES leads that this behavior is desired for aspecs.
I have tested 3 example cases: 1 where we were missing 2 modes (AV-304), one where no modes were missing (AV-456), and one where only 1 grating contributes to the target at all (CVSO-35). They all changed as expected which is:
AV-304 included the missing modes in aspecs now (including a completely new aspec file). All other files identical.
AV-456 only changed in the aspec files, and all that changed was the transition points because we are now using HASP strategy. All other files identical.
CVSO-35 did not change at all because it has no aspecs. All files identical.
We only used the new HASP abut strategy for level 4 (preview-spec) products. We neglected to use it also for level 3 (aspec). Because of this, aspecs were being created in the same method as previous DRs. The gratings that contribute to each aspec were hardcoded, because they are grouped by resolution. However, as we added more non-ULLYSES data (i.e. AR data), we did not update this hardcoded list. This led to some AR modes not being included in aspecs.
There were two solutions. 1) Simply add the missing gratings to the hardcoded list. This does not address the issues that level 3 products are using the old abut strategy. 2) Add missing gratings to hardcoded list AND use new abut strategy. This is what I did. *Note that I also followed the currently implemented logic which is to NOT make an aspec when only 1 mode exists for a resolution grouping. I checked with ULLYSES leads that this behavior is desired for aspecs.
I have tested 3 example cases: 1 where we were missing 2 modes (AV-304), one where no modes were missing (AV-456), and one where only 1 grating contributes to the target at all (CVSO-35). They all changed as expected which is: