WFIRST Cycle 7 Updates - Githubissues

spacetelescope / webbpsf

James Webb Space Telescope PSF simulation tool

https://webbpsf.readthedocs.io

BSD 3-Clause "New" or "Revised" License

119 stars 63 forks source link

WFIRST Cycle 7 Updates #176

Closed mperrin closed 6 years ago

mperrin commented 6 years ago

Issue by robelgeda Wednesday Nov 08, 2017 at 21:43 GMT Originally opened as https://github.com/mperrin/webbpsf/pull/176

This is the final draft of WFIRST Cycle 7 updates. The Following changes have been made:

webbpsf:

Edits to pupil file names.
Edits to Zernike file name.

webbpsf-data-source:

New filter: WFI/filters/R062_throughput.fits.
Edit: WFI/filters.tsv to add R062.
Updated Zernike Coefficients: WFI/wim_zernikes_cycle7.csv.
Updated Pupils: WFIRST_SRR_WFC_Pupil_Mask_Longwave_2048.fits and WFIRST_SRR_WFC_Pupil_Mask_Shortwave_2048.fits.
Old Zernike Coeff moved to: WFI/sources/cycle6/WFI/wim_zernikes_cycle6.csv
Old Pupils moved to: _Obsolete/cycle6_pupils/..
Data generation material stored in WFI/sources/cycle7.

robelgeda included the following code: https://github.com/mperrin/webbpsf/pull/176/commits

mperrin commented 6 years ago

Comment by mperrin Wednesday Nov 08, 2017 at 22:00 GMT

Can you explain a bit more about the pupil updates? What were you able to figure out about the coordinate system conventions?

mperrin commented 6 years ago

Comment by robelgeda Thursday Nov 09, 2017 at 13:10 GMT

I was able to obtain the instrument layout in both cycles. Both indicate that the coordinate system is Payload FOV {X, Y}. See axis labels below:

I was able to figure out that the WSM rotated 90 degrees as follows.

Where purple and orange arrows point to the origin in cycle 6 and 7 respectively.

After that I checked if the pupil files do the same transformation.

I found this to be evidence that the pupil coordinate system conventions are the same.

mperrin commented 6 years ago

Comment by robelgeda Thursday Nov 09, 2017 at 15:22 GMT

@mperrin: Also, the people at Goddard shared a script to convert the pupil from tiffs to fits. One thing to note is that I had to flip the image upside down (edited the code they sent) because the y axis of a fits file starts to index at the top left (as opposed to the image reader which indexes at the bottom left).

mperrin commented 6 years ago

Comment by robelgeda Wednesday Nov 15, 2017 at 21:33 GMT

I tested the changes using the example Jupyter netbooks and the /webbpsf/tests/test_wfits.py script. Everything seems to be in order.