search

spacetelescope / webbpsf

James Webb Space Telescope PSF simulation tool
https://webbpsf.readthedocs.io
BSD 3-Clause "New" or "Revised" License
119 stars 63 forks source link

Improved: SI WFE interpolation #187

Closed mperrin closed 6 years ago

mperrin commented 6 years ago

Issue by robelgeda Friday Feb 02, 2018 at 17:08 GMT Originally opened as https://github.com/mperrin/webbpsf/pull/187

Improved version of PR #174. Zernike values are interpolated using scipy.interpolate.griddata's cubic method. This gives the best approximations and adds smallest overhead.

robelgeda included the following code: https://github.com/mperrin/webbpsf/pull/187/commits

mperrin commented 6 years ago

Comment by mperrin Friday Feb 02, 2018 at 21:16 GMT

I'm confused - what is improved in this versus #174? Looks identical to me.

mperrin commented 6 years ago

Comment by mperrin Friday Feb 02, 2018 at 21:18 GMT

Is the only difference the call to np.isnan() for checking for invalid interpolation outputs and then using the nearest neighbor instead?

mperrin commented 6 years ago

Comment by robelgeda Friday Feb 02, 2018 at 21:29 GMT

Yes, also the range of the Zernike for loop should be 1->37 instead of 1->36.

mperrin commented 6 years ago

Comment by robelgeda Tuesday Feb 20, 2018 at 21:14 GMT

@mperrin I fixed the conflict. At this point the only difference is the for loop range.

mperrin commented 6 years ago

Comment by mperrin Tuesday Feb 20, 2018 at 23:22 GMT

OK, it looks like the actual code tests are fine for this; the Travis build is failing because of the docs issue (#193), not because of this change. So I'm going to go ahead and merge it.

@robelgeda, any chance you might be able to try to dig into the docs build problems (for webbpsf and poppy both) over the next few days sometime? See #193.