Need to re-import influence function file using a more recent WSS IFM, to fix RoC inconsistency

spacetelescope / webbpsf

James Webb Space Telescope PSF simulation tool

https://webbpsf.readthedocs.io

BSD 3-Clause "New" or "Revised" License

119 stars 63 forks source link

Need to re-import influence function file using a more recent WSS IFM, to fix RoC inconsistency #399

Open mperrin opened 3 years ago

mperrin commented 3 years ago

As discovered & discussed in WFTP10, there was a sign error in Ball's IFM for RoC, which they fixed a couple years ago but which wasn't yet propagated to WebbPSF. We should fix that in a new IFM.

Relatedly there's also some slight rotation cross-term in the tip tilts for the segments; this could also be fixed once Scott makes an updated IFM replacement.

More generally, the import script and toolkit to generate the IFM should be added into the dev_utils folder.

mperrin commented 3 years ago

Note, a hack fix for this was added to https://github.com/spacetelescope/webbpsf/pull/392; but that's pretty much just a temporary work around for now in WFTP10.