search

spacetelescope / webbpsf

James Webb Space Telescope PSF simulation tool
https://webbpsf.readthedocs.io
BSD 3-Clause "New" or "Revised" License
119 stars 63 forks source link

[SCSB-145] require Python 3.10 #817

Closed zacharyburnett closed 7 months ago

zacharyburnett commented 7 months ago

resolves SCSB-145

propagate Astropy's deprecation of Python 3.9 to downstream packages

[!NOTE] this PR was generated automatically by batchpr :robot:

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 60.58%. Comparing base (63f7231) to head (fc2b68c). Report is 2 commits behind head on develop.

:exclamation: Current head fc2b68c differs from pull request most recent head 9e2d170. Consider uploading reports for the commit 9e2d170 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #817 +/- ## ======================================== Coverage 60.58% 60.58% ======================================== Files 16 16 Lines 6649 6649 ======================================== Hits 4028 4028 Misses 2621 2621 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

BradleySappington commented 7 months ago

Thanks @zacharyburnett, I think that tox.ini and ci_workflows should be updated as well with this PR? The latter is causing errors trying to install '3.1' which is peculiar...

BradleySappington commented 7 months ago

@zacharyburnett - looks like tox still has references to 3.9 and can be moved from 3.10 - 3.12 in the environment setups. Also pyproject.toml will probably need numpy >=1.21.6

mperrin commented 7 months ago

@BradleySappington @zacharyburnett - I wanted to check in for a status on this PR? It would be nice to get this merged in soon if possible, since the py3.9 lack of support is causing test failures for other PRs at this point. Thanks!

zacharyburnett commented 7 months ago

@BradleySappington @zacharyburnett - I wanted to check in for a status on this PR? It would be nice to get this merged in soon if possible, since the py3.9 lack of support is causing test failures for other PRs at this point. Thanks!

I apologize! I have been occupied by the JWST pipeline release and regression tests; these commits look good to me!

mperrin commented 7 months ago

Thank you both!

And no worries, no need to apologize @zacharyburnett. I completely sympathize on having too many things to be occupied with, ha. All too often...