search

spacetelescope / webbpsf

James Webb Space Telescope PSF simulation tool
https://webbpsf.readthedocs.io
BSD 3-Clause "New" or "Revised" License
115 stars 62 forks source link

Allow setup_sim_to_match_data to select choice of WFS before or after #819

Closed mperrin closed 5 months ago

mperrin commented 5 months ago

Simple PR to add a keyword passthrough. This lets the choice='before' or 'after' parameter be used with the setup_sim_to_match_data function, and get passed to load_wss_opd_by_date.

Also adds a missing docstring for setup_sim_to_match_data.

pep8speaks commented 5 months ago

Hello @mperrin, Thank you for submitting the Pull Request !

Line 1:1: E266 too many leading '#' for block comment Line 25:38: E231 missing whitespace after ',' Line 36:17: E225 missing whitespace around operator Line 36:46: E225 missing whitespace around operator Line 39:20: E225 missing whitespace around operator Line 41:20: E225 missing whitespace around operator Line 44:51: E226 missing whitespace around arithmetic operator Line 44:55: E226 missing whitespace around arithmetic operator Line 48:5: E303 too many blank lines (2) Line 53:76: E114 indentation is not a multiple of four (comment) Line 53:76: E116 unexpected indentation (comment) Line 57:37: E226 missing whitespace around arithmetic operator

If you have not done so, please lint your code in accordance with best practices.

codecov[bot] commented 5 months ago

Codecov Report

Attention: Patch coverage is 50.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 60.58%. Comparing base (63f7231) to head (5e46e8d).

Files Patch % Lines
webbpsf/match_data.py 50.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #819 +/- ## ======================================== Coverage 60.58% 60.58% ======================================== Files 16 16 Lines 6649 6649 ======================================== Hits 4028 4028 Misses 2621 2621 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mperrin commented 5 months ago

The test failures are due to trying to run on py 3.9, now deprecated. That's fixed elsewhere (#817) so is not a concern for this PR. Going to merge anyway regardless of those failed tests.