Autofix linting, and formatting updates

[BradleySappington]

Massive non functional ruff formatting/linting updates

[pep8speaks]

Hello @BradleySappington, Thank you for updating !

• In the file dev_utils/compute_psf_library.py:

Line 19:1: E402 module level import not at top of file

• In the file dev_utils/field_dependence/basis.py:

Line 24:1: E402 module level import not at top of file Line 30:1: E402 module level import not at top of file Line 36:1: E402 module level import not at top of file Line 215:28: E203 whitespace before ':'

• In the file dev_utils/field_dependence/read_codev_dat_fits.py:

Line 5:1: E402 module level import not at top of file Line 7:1: E402 module level import not at top of file Line 8:1: E402 module level import not at top of file

• In the file dev_utils/package_filters.py:

Line 27:5: E722 do not use bare 'except'

• In the file docs/roman_figures/how_tos.py:

Line 4:1: E266 too many leading '#' for block comment Line 35:1: E266 too many leading '#' for block comment Line 54:1: E266 too many leading '#' for block comment

• In the file webbpsf/detectors.py:

Line 64:9: E266 too many leading '#' for block comment Line 111:9: E722 do not use bare 'except'

• In the file webbpsf/gridded_library.py:

Line 542:5: E731 do not assign a lambda expression, use a def

• In the file webbpsf/mast_wss.py:

Line 17:1: E266 too many leading '#' for block comment Line 58:1: E266 too many leading '#' for block comment Line 217:1: E266 too many leading '#' for block comment Line 291:1: E266 too many leading '#' for block comment

• In the file webbpsf/opds.py:

Line 1412:13: E722 do not use bare 'except'

• In the file webbpsf/optical_budget.py:

Line 12:1: E266 too many leading '#' for block comment Line 187:5: E731 do not assign a lambda expression, use a def Line 291:15: W605 invalid escape sequence '\c' Line 297:51: W605 invalid escape sequence '\s'

• In the file webbpsf/optics.py:

Line 20:1: E266 too many leading '#' for block comment Line 184:1: E266 too many leading '#' for block comment Line 727:13: E722 do not use bare 'except' Line 876:71: E712 comparison to False should be 'if cond is False:' or 'if not cond:' Line 1307:52: E203 whitespace before ':' Line 1307:70: E203 whitespace before ':' Line 1892:9: E266 too many leading '#' for block comment

• In the file webbpsf/roman.py:

Line 23:1: E402 module level import not at top of file Line 288:63: E712 comparison to True should be 'if cond is True:' or 'if cond:'

• In the file webbpsf/tests/test_errorhandling.py:

Line 11:1: E402 module level import not at top of file Line 13:1: E402 module level import not at top of file

• In the file webbpsf/tests/test_fgs.py:

Line 9:1: E402 module level import not at top of file Line 11:1: E731 do not assign a lambda expression, use a def Line 12:1: E731 do not assign a lambda expression, use a def Line 13:1: E731 do not assign a lambda expression, use a def Line 15:1: E731 do not assign a lambda expression, use a def

• In the file webbpsf/tests/test_miri.py:

Line 11:1: E402 module level import not at top of file Line 14:1: E402 module level import not at top of file Line 16:1: E731 do not assign a lambda expression, use a def Line 17:1: E731 do not assign a lambda expression, use a def Line 18:1: E731 do not assign a lambda expression, use a def Line 20:1: E731 do not assign a lambda expression, use a def

• In the file webbpsf/tests/test_nircam.py:

Line 12:1: E402 module level import not at top of file Line 14:1: E402 module level import not at top of file Line 16:1: E402 module level import not at top of file Line 17:1: E402 module level import not at top of file Line 20:1: E402 module level import not at top of file Line 22:1: E731 do not assign a lambda expression, use a def Line 23:1: E731 do not assign a lambda expression, use a def Line 24:1: E731 do not assign a lambda expression, use a def Line 26:1: E731 do not assign a lambda expression, use a def Line 28:1: E731 do not assign a lambda expression, use a def Line 29:1: E731 do not assign a lambda expression, use a def Line 193:5: E731 do not assign a lambda expression, use a def Line 251:5: E731 do not assign a lambda expression, use a def Line 388:21: E712 comparison to False should be 'if cond is False:' or 'if not cond:'

• In the file webbpsf/tests/test_niriss.py:

Line 10:1: E731 do not assign a lambda expression, use a def Line 11:1: E731 do not assign a lambda expression, use a def Line 12:1: E731 do not assign a lambda expression, use a def Line 14:1: E731 do not assign a lambda expression, use a def

• In the file webbpsf/tests/test_nirspec.py:

Line 10:1: E402 module level import not at top of file Line 13:1: E402 module level import not at top of file Line 15:1: E731 do not assign a lambda expression, use a def Line 20:1: E731 do not assign a lambda expression, use a def Line 21:1: E731 do not assign a lambda expression, use a def Line 23:1: E731 do not assign a lambda expression, use a def

• In the file webbpsf/tests/test_opds.py:

Line 180:36: E712 comparison to False should be 'if cond is False:' or 'if not cond:' Line 316:5: E731 do not assign a lambda expression, use a def

• In the file webbpsf/tests/test_roman.py:

Line 182:5: E731 do not assign a lambda expression, use a def Line 185:5: E731 do not assign a lambda expression, use a def

• In the file webbpsf/tests/test_utils.py:

Line 6:1: E722 do not use bare 'except' Line 14:1: E402 module level import not at top of file Line 15:1: E402 module level import not at top of file Line 46:5: E722 do not use bare 'except'

• In the file webbpsf/tests/test_webbpsf.py:

Line 10:1: E402 module level import not at top of file Line 12:1: E402 module level import not at top of file Line 13:1: E402 module level import not at top of file Line 218:5: E722 do not use bare 'except'

• In the file webbpsf/tests/validate_webbpsf.py:

Line 44:34: W605 invalid escape sequence '\m' Line 1450:9: E266 too many leading '#' for block comment Line 1588:43: W605 invalid escape sequence '\m' Line 1589:40: W605 invalid escape sequence '\m' Line 1620:5: E722 do not use bare 'except' Line 1782:34: E262 inline comment should start with '# '

• In the file webbpsf/trending.py:

Line 88:9: E265 block comment should start with '# ' Line 90:9: E265 block comment should start with '# ' Line 91:9: E265 block comment should start with '# ' Line 97:9: E265 block comment should start with '# ' Line 273:25: E712 comparison to False should be 'if cond is False:' or 'if not cond:' Line 275:27: E712 comparison to True should be 'if cond is True:' or 'if cond:' Line 339:35: E203 whitespace before ':' Line 405:1: E266 too many leading '#' for block comment Line 612:5: E266 too many leading '#' for block comment Line 627:5: E266 too many leading '#' for block comment Line 662:5: E266 too many leading '#' for block comment Line 685:5: E266 too many leading '#' for block comment Line 839:5: E266 too many leading '#' for block comment Line 921:49: W605 invalid escape sequence '\D' Line 955:1: E266 too many leading '#' for block comment Line 984:43: E203 whitespace before ':' Line 1074:5: E722 do not use bare 'except' Line 1221:5: E266 too many leading '#' for block comment Line 1238:5: E266 too many leading '#' for block comment Line 1251:118: W605 invalid escape sequence '\D' Line 1538:5: E731 do not assign a lambda expression, use a def Line 1785:25: W605 invalid escape sequence '\D' Line 1793:1: E266 too many leading '#' for block comment Line 1872:9: E266 too many leading '#' for block comment Line 1900:13: E266 too many leading '#' for block comment Line 1920:9: E266 too many leading '#' for block comment

• In the file webbpsf/utils.py:

Line 16:1: E402 module level import not at top of file Line 23:1: E266 too many leading '#' for block comment Line 162:1: E266 too many leading '#' for block comment Line 390:5: E722 do not use bare 'except' Line 395:9: E722 do not use bare 'except' Line 403:46: E721 do not compare types, use 'isinstance()' Line 437:1: E266 too many leading '#' for block comment Line 535:33: E203 whitespace before ':' Line 535:50: E203 whitespace before ':' Line 536:43: E203 whitespace before ':' Line 536:60: E203 whitespace before ':' Line 636:1: E266 too many leading '#' for block comment

• In the file webbpsf/webbpsf_core.py:

Line 700:1: E266 too many leading '#' for block comment Line 1692:13: E731 do not assign a lambda expression, use a def Line 1694:13: E731 do not assign a lambda expression, use a def Line 1713:9: E266 too many leading '#' for block comment Line 1736:9: E266 too many leading '#' for block comment Line 1737:9: E266 too many leading '#' for block comment

Comment last updated at 2024-05-09 15:10:40 UTC

[BradleySappington]

@mperrin and @obi-wan76 - The changes in these files have all been completed using ruff check . --autofix It should predominantly be formatting changes, and most of them are quote style changes. You shouldn't see any "highlighted" changes that look like logic changes in your review, and if you do we should discuss (I will also personally review everything).

This is the first of the code clean PRS and should be pretty straight forward.

[BradleySappington]

@mperrin and @obi-wan76 - I'm going to include one more commit with more auto-formatting changes for files that require manual intervention. That way, when I do the manual intervention, there wont be formatting changes mucking up the compare. I will tag you when ready for review (probably tomorrow)

[BradleySappington]

@mperrin and @obi-wan76 - Ready for review. Again, all of these changes were deemed the "safe" options for autoformat. I didn't include any "unsafe" changes, that will be a future PR. So this massive change set should be straightforward.

[BradleySappington]

FYI: I just went through all the code and feel comfortable with this change set.

[BradleySappington]

switching to new branch with different rules