search

spacetelescope / webbpsf

James Webb Space Telescope PSF simulation tool
https://webbpsf.readthedocs.io
BSD 3-Clause "New" or "Revised" License
119 stars 63 forks source link

Implement support for NIRCam DHS sub apertures #845

Closed mperrin closed 6 months ago

mperrin commented 6 months ago

Implements support for computing monochromatic PSFs for the NIRCam Dispersed Hartmann Sensor (DHS) mode. Intended for ETC PSF generation in support of implementing a TSO mode using the DHS.

Requires updated data files to work.

pep8speaks commented 6 months ago

Hello @mperrin, Thank you for submitting the Pull Request !

Line 306:126: E501 line too long (148 > 125 characters) Line 760:1: E266 too many leading '#' for block comment Line 983:126: E501 line too long (133 > 125 characters) Line 995:126: E501 line too long (145 > 125 characters) Line 1014:126: E501 line too long (134 > 125 characters) Line 1410:126: E501 line too long (200 > 125 characters) Line 1565:126: E501 line too long (131 > 125 characters) Line 1800:13: E731 do not assign a lambda expression, use a def Line 1802:13: E731 do not assign a lambda expression, use a def Line 1821:9: E266 too many leading '#' for block comment Line 1852:9: E266 too many leading '#' for block comment Line 1853:9: E266 too many leading '#' for block comment Line 1915:126: E501 line too long (127 > 125 characters) Line 2067:126: E501 line too long (141 > 125 characters) Line 2353:126: E501 line too long (130 > 125 characters) Line 2397:126: E501 line too long (130 > 125 characters) Line 2407:126: E501 line too long (141 > 125 characters) Line 2431:126: E501 line too long (130 > 125 characters) Line 2668:23: E272 multiple spaces before keyword Line 2783:126: E501 line too long (134 > 125 characters)

If you have not done so, please lint your code in accordance with best practices.