Closed mperrin closed 2 months ago
Hello @mperrin, Thank you for updating !
webbpsf/trending.py
:Line 386:70: E226 missing whitespace around arithmetic operator Line 390:17: E124 closing bracket does not match visual indentation
Looks great! Did some testing with the various options and it works well with changing the min,max values as well as the correction markers.
Improves the
trending.wfe_histogram_plot
arrow markers to show corrections.matplotlib.annotate
to draw the arrows, instead of separate calls to plot lines and draw triangle markers. This ultimately is cleaner but ended up taking a while to figure out since there's a ridiculously complicated set of options to the arrow-drawing functions.min_wfe
andmax_wfe
options to that function, which can be used to directly set custom min and max ranges if the defaults aren't suitable in some particular case. The histogram and cumulative histogram display is updates to clip values, such that values outside of min and max are still included in the histogram at the extreme bottom or top bin of the histogram, respectively.Example output:
Separately, this PR also has a minor fix to some unrelated display issues elsewhere in
trending.py
, by settingclip_on=True
in a couple function calls, to prevent labels being drawn outside of axes sometimes depending on x and y ranges there. This is mostly unrelated but is convenient to combine into this same PR.