spacetelescope / webbpsf

James Webb Space Telescope PSF simulation tool
https://webbpsf.readthedocs.io
BSD 3-Clause "New" or "Revised" License
115 stars 61 forks source link

Improve trending plots, particularly wfe_histogram arrows display #870

Closed mperrin closed 2 months ago

mperrin commented 2 months ago

Improves the trending.wfe_histogram_plot arrow markers to show corrections.

Example output:

Unknown-12

Separately, this PR also has a minor fix to some unrelated display issues elsewhere in trending.py, by setting clip_on=True in a couple function calls, to prevent labels being drawn outside of axes sometimes depending on x and y ranges there. This is mostly unrelated but is convenient to combine into this same PR.

pep8speaks commented 2 months ago

Hello @mperrin, Thank you for updating !

Line 386:70: E226 missing whitespace around arithmetic operator Line 390:17: E124 closing bracket does not match visual indentation

Comment last updated at 2024-06-11 19:05:15 UTC
kulpster85 commented 2 months ago

Looks great! Did some testing with the various options and it works well with changing the min,max values as well as the correction markers.