search

spacetelescope / webbpsf

James Webb Space Telescope PSF simulation tool
https://webbpsf.readthedocs.io
BSD 3-Clause "New" or "Revised" License
115 stars 61 forks source link

use `pathlib` to handle a `WEBBPSF_PATH` with double slashes #886

Closed zacharyburnett closed 1 month ago

zacharyburnett commented 1 month ago

to handle cases such as

E           OSError: WEBBPSF_PATH (/home/runner/work/_temp/data//webbpsf-data/) is not a valid directory path!

https://github.com/spacetelescope/romancal/actions/runs/9974996761/job/27563753075#step:10:305

pep8speaks commented 1 month ago

Hello @zacharyburnett, Thank you for updating !

There are no PEP8 issues in this Pull Request.

Comment last updated at 2024-07-17 14:39:03 UTC
BradleySappington commented 1 month ago

@zacharyburnett , code approved for pathlib handling, however please fix the pep8speaks suggestion (and tests working)

zacharyburnett commented 1 month ago

@zacharyburnett , code approved for pathlib handling, however please fix the pep8speaks suggestion (and tests working)

the tests are blocked by #885 (and https://github.com/spacetelescope/webbpsf/actions/workflows/download_data.yml needs to be rerun after that merge)