Open mperrin opened 1 month ago
Hello @mperrin, Thank you for updating !
webbpsf/detectors.py
:Line 564:1: E101 indentation contains mixed spaces and tabs Line 567:1: E101 indentation contains mixed spaces and tabs Line 568:1: E101 indentation contains mixed spaces and tabs Line 570:1: E101 indentation contains mixed spaces and tabs Line 616:91: E225 missing whitespace around operator Line 616:91: W504 line break after binary operator Line 642:1: E101 indentation contains mixed spaces and tabs Line 643:1: E101 indentation contains mixed spaces and tabs Line 645:55: E226 missing whitespace around arithmetic operator Line 645:66: E226 missing whitespace around arithmetic operator Line 645:71: E226 missing whitespace around arithmetic operator Line 645:126: E501 line too long (138 > 125 characters) Line 647:31: E226 missing whitespace around arithmetic operator Line 648:35: E226 missing whitespace around arithmetic operator Line 653:6: E111 indentation is not a multiple of four Line 653:6: E117 over-indented Line 665:6: E111 indentation is not a multiple of four Line 669:6: E111 indentation is not a multiple of four Line 670:10: E111 indentation is not a multiple of four Line 671:6: E111 indentation is not a multiple of four Line 672:10: E111 indentation is not a multiple of four Line 673:10: E111 indentation is not a multiple of four Line 674:10: E111 indentation is not a multiple of four Line 675:6: E111 indentation is not a multiple of four
webbpsf/tests/test_nirspec.py
:Line 119:1: W391 blank line at end of file
webbpsf/webbpsf_core.py
:Line 2074:19: E126 continuation line over-indented for hanging indent Line 2075:13: E131 continuation line unaligned for hanging indent
@patapisp FYI, I have started moving functionality from your PR #691 to this one for the MIRI MRS PSF models. I don't know if you might have some time to help check it, or to advise things that I should look at to check the result myself? I know you're busy and time is short but let me know if there might be time we could chat on this soon. Cheers!
Attention: Patch coverage is 82.19178%
with 13 lines
in your changes missing coverage. Please review.
Project coverage is 62.13%. Comparing base (
b536111
) to head (be50906
). Report is 162 commits behind head on develop.
Files | Patch % | Lines |
---|---|---|
webbpsf/match_data.py | 0.00% | 9 Missing :warning: |
webbpsf/detectors.py | 92.85% | 4 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@mperrin happy to check it out and test it.
Continues IFU model improvements work started in #770.
To Do: