IFU mode improvements, continued

[mperrin]

Continues IFU model improvements work started in #770.

• [x] Adds a framework for, in IFU mode, after the initial PSF calculation completes calling a function to apply some transformation (e.g. a broadening convolution kernel) to improve the IFU model fidelity.
• [x] For now, implements an initial placeholder version of that for NIRSpec and MIRI each as a simple Gaussian convolution kernel. This will be improved subsequently.
• [x] Adds unit test functions for both NIRSpec and MIRI.
• [x] Minor improvements to logging outputs etc, incidental as part of testing and verifying the above

To Do:

• [ ] Improved convolution kernel method for NIRSpec IFU
• [ ] Improved convolution kernel method for MIRI MRS, based on parameters from #691
• [ ] Further verification and validation compared to in-flight PSF calibrations.

[pep8speaks]

Hello @mperrin, Thank you for updating !

• In the file webbpsf/detectors.py:

Line 564:1: E101 indentation contains mixed spaces and tabs Line 567:1: E101 indentation contains mixed spaces and tabs Line 568:1: E101 indentation contains mixed spaces and tabs Line 570:1: E101 indentation contains mixed spaces and tabs Line 616:91: E225 missing whitespace around operator Line 616:91: W504 line break after binary operator Line 642:1: E101 indentation contains mixed spaces and tabs Line 643:1: E101 indentation contains mixed spaces and tabs Line 645:55: E226 missing whitespace around arithmetic operator Line 645:66: E226 missing whitespace around arithmetic operator Line 645:71: E226 missing whitespace around arithmetic operator Line 645:126: E501 line too long (138 > 125 characters) Line 647:31: E226 missing whitespace around arithmetic operator Line 648:35: E226 missing whitespace around arithmetic operator Line 653:6: E111 indentation is not a multiple of four Line 653:6: E117 over-indented Line 665:6: E111 indentation is not a multiple of four Line 669:6: E111 indentation is not a multiple of four Line 670:10: E111 indentation is not a multiple of four Line 671:6: E111 indentation is not a multiple of four Line 672:10: E111 indentation is not a multiple of four Line 673:10: E111 indentation is not a multiple of four Line 674:10: E111 indentation is not a multiple of four Line 675:6: E111 indentation is not a multiple of four

• In the file webbpsf/tests/test_nirspec.py:

Line 119:1: W391 blank line at end of file

• In the file webbpsf/webbpsf_core.py:

Line 2074:19: E126 continuation line over-indented for hanging indent Line 2075:13: E131 continuation line unaligned for hanging indent

Comment last updated at 2024-07-26 21:56:13 UTC

[mperrin]

@patapisp FYI, I have started moving functionality from your PR #691 to this one for the MIRI MRS PSF models. I don't know if you might have some time to help check it, or to advise things that I should look at to check the result myself? I know you're busy and time is short but let me know if there might be time we could chat on this soon. Cheers!

[codecov[bot]]

Codecov Report

Attention: Patch coverage is 82.19178% with 13 lines in your changes missing coverage. Please review.

Project coverage is 62.13%. Comparing base (b536111) to head (be50906). Report is 162 commits behind head on develop.

Files	Patch %	Lines
webbpsf/match_data.py	0.00%	9 Missing :warning:
webbpsf/detectors.py	92.85%	4 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## develop #890 +/- ## =========================================== + Coverage 59.20% 62.13% +2.92% =========================================== Files 16 15 -1 Lines 6955 7003 +48 =========================================== + Hits 4118 4351 +233 + Misses 2837 2652 -185 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

[patapisp]

@mperrin happy to check it out and test it.