Enhance capabilities to simulate PSFs with larger JWST pupil

spacetelescope / webbpsf

James Webb Space Telescope PSF simulation tool

https://webbpsf.readthedocs.io

BSD 3-Clause "New" or "Revised" License

119 stars 63 forks source link

Enhance capabilities to simulate PSFs with larger JWST pupil #908

Closed obi-wan76 closed 2 months ago

obi-wan76 commented 2 months ago

This PR is for enhance capabilities to simulate PSFs with larger JWST pupils. The changes are only in the load_wss functions in order to match the observed OPD to the larger pupil sizes. This PR also adds documentation for this enhance support.

pep8speaks commented 2 months ago

Hello @obi-wan76, Thank you for updating !

In the file webbpsf/webbpsf_core.py:

Line 1649:19: E126 continuation line over-indented for hanging indent

Comment last updated at 2024-09-12 11:53:31 UTC

obi-wan76 commented 2 months ago

@mperrin thanks for making the changes, it looks good. I cannot approve it because I am the author but you can go ahead and approve it. btw, you are right about the OPD path, I changed the file locally but did not add it to this PR, thanks for fixing my mistake!