search

spacetelescope / webbpsf

James Webb Space Telescope PSF simulation tool
https://webbpsf.readthedocs.io
BSD 3-Clause "New" or "Revised" License
119 stars 63 forks source link

Roman docs & figures updates #910

Closed Skyhawk172 closed 2 months ago

Skyhawk172 commented 2 months ago

I updated the figures under the "Roman Instrument Model Details" section of the documentation as it appeared they had not been updated with the latest optical model (see GIF). The how_tos.py was also modified in order to rearrange the first figure.

I also updated the caption to one of the figures to clearly state that the prism and grism PSFs shown are monochromatic.

Finally, I updated the Roman notebook, in particular by adding how to use the datacube() function for the spectroscopic "filters".

Note: there are no differences in the Roman CGI figures after re-running the code to generate the figure, so no update needed.

POST-FACTO EDIT: The root cause of the difference was tracked down to the fix for https://github.com/spacetelescope/webbpsf/issues/666, which was rolled out as part of v1.2.0.

RomanWebbPSF

pep8speaks commented 2 months ago

Hello @Skyhawk172, Thank you for updating !

There are no PEP8 issues in this Pull Request.

Comment last updated at 2024-09-11 20:03:00 UTC