search

spacetelescope / webbpsf

James Webb Space Telescope PSF simulation tool
https://webbpsf.readthedocs.io
BSD 3-Clause "New" or "Revised" License
119 stars 63 forks source link

update ifu docs to describe about coord_system and pixel scale #923

Closed mperrin closed 6 days ago

mperrin commented 4 weeks ago

Improve docs to address some of the questions from that help desk ticket.

mperrin commented 4 weeks ago

Huh. A few of the tests for this docs PR fail, in a way that’s completely unrelated to docs, which is the only thing that changed in this PR. Must be some kind of upstream change or dependency issue?? FYI @obi-wan76 @BradleySappington Maybe one of you could investigate

BradleySappington commented 4 weeks ago

@mperrin, looks like photutils updated to version 2.0.2, last successful run it was 1.13.0

BradleySappington commented 6 days ago

@mperrin - I pushed updates to develop that I believe should fix this issue. If you would please merge develop into your update_ifu_docs repo, this pr should fall out and pass all tests. I also raised an issue for the cause of this failure that will need to be addressed separately.

codecov[bot] commented 6 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 62.15%. Comparing base (490d6bf) to head (2dc5d45). Report is 19 commits behind head on develop.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #923 +/- ## ======================================== Coverage 62.15% 62.15% ======================================== Files 15 15 Lines 7016 7016 ======================================== Hits 4361 4361 Misses 2655 2655 ``` | [Flag](https://app.codecov.io/gh/spacetelescope/webbpsf/pull/923/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=spacetelescope) | Coverage Δ | | |---|---|---| | [](https://app.codecov.io/gh/spacetelescope/webbpsf/pull/923/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=spacetelescope) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=spacetelescope#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

🚨 Try these New Features: