Pass calwf3 output - Githubissues

spacetelescope / wfc3tools

Python tools for HST WFC3 data calibration and analysis

https://wfc3tools.readthedocs.io/en/latest/

Other

6 stars 19 forks source link

Pass calwf3 output #2

Closed josePhoenix closed 8 years ago

josePhoenix commented 8 years ago

Two proposed changes:

Allow passing of a log function that is called with output lines of text from the calwf3.e subprocess object (default: print(), None to disable)
Check the exit code of calwf3.e

This came about from using calwf3 in a Jupyter notebook and wanting some more visibility into what it was doing.

sosey commented 8 years ago

@josePhoenix Sorry, I saw your pull request a couple days ago and realized I had to finish restructuring and updating the package from our move. I'm about done, hopefully will push today.

I'll accept this ahead of my push if you also add the documentation for the update in the sphinx docs for users. Then I'll take care of the merge in my pull.

josePhoenix commented 8 years ago

Sure, did you mean in docs/source/calwf3.rst, or somewhere else?

sosey commented 8 years ago

Yah, that's prolly the right place