search

spacetelescope / wfc3tools

Python tools for HST WFC3 data calibration and analysis
https://wfc3tools.readthedocs.io/en/latest/
Other
6 stars 19 forks source link

changes to setup, remove teal #63

Closed cshanahan1 closed 2 years ago

cshanahan1 commented 2 years ago

Made changes to setup files to install dependencies and remove 'relic' I also removed some pytest setup since there are currently no tests in this package. I also removed everything related to 'teal'.

pllim commented 2 years ago

p.s. I see Matt R put in https://github.com/spacetelescope/wfc3tools/blob/master/.github/workflows/publish-to-pypi.yml but that does not run as CI and not very sure how you ask it to only run as packaging test but not upload anything. Anyways, you cannot have two publish workflows, so you need to delete this one if you are going to add the other one to CI.

nden commented 2 years ago

As Pey-Lian mentioned - add a pyproject.toml file. Then refactor __init__.py to define __version__ similar to other packages.

pllim commented 2 years ago

@FDauphin , all the metadata should now be in setup.cfg. And __version__ is generated by setuptools_scm. You don't need from __future__.

cshanahan1 commented 2 years ago

I'm removing doc related extras in setup.cfg. I'm going to open up another PR with all the doc stuff. Theres a lot in there and I want to distill it down to what is actually required.

pllim commented 2 years ago

In terms of packaging, testing source install isn't enough. You want to make sure you are able to build sdist and wheel, and then install those and get a full package back. I recently had to help debug another package that accidentally released an empty wheel.

nden commented 2 years ago

I built and tested a source package and a wheel. I can confirm they work.

nden commented 2 years ago

@pllim The idea for this PR is to make the build scripts up to date and release so we can start putting together and testing a larger HST distribution. The documentation will come in the next PR, followed by a new release but meanwhile we can work on the larger HST distribution. Is there anything else you would like to see done for this PR?

cshanahan1 commented 2 years ago

ok thanks everyone! im going to merge this now

FDauphin commented 2 years ago

@cshanahan1 thanks for your work on this! Michele followed up and said as long as drizzlepac (which still uses TEAL) isn't used in wfc3tools, we can remove TEAL. wfc3tools doesn't use drizzlepac so removing TEAL was the right move.