search

spacetelescope / wfc3tools

Python tools for HST WFC3 data calibration and analysis
https://wfc3tools.readthedocs.io/en/latest/
Other
6 stars 19 forks source link

update calwf3 docstring #74

Closed bjkuhn closed 1 year ago

bjkuhn commented 1 year ago

removed the Version parameter from docstring since the parameter was deleted in PR#64. I also added an example of how one can check the current version of calwf3.

bjkuhn commented 1 year ago

This PR is should be attached to Issue #72. Once the PR is approved and merged, Issue #72 should be resolved

bjkuhn commented 1 year ago

@cshanahan1, here is Issue #72 as a PR

mdlpstsci commented 1 year ago

@bjkuhn Sorry I did not notice this PR when I was fixing calwf3.py. PR#85 fixes the issue with the version parameter so that PR#77 can have passing tests as the regression test, test_wfc3.py (test_version_print) was failing. The "version" parameter is legitimate so I restored it, updated all corresponding documentation, added an example, and documented when the "version" parameter is used, if any filename is specified, it is ignored. I also removed the "output" parameter as this is NOT supported by the underlying C code.

PR#85 surpersedes PR (for this I apologize) as well as Issue #72.