spacetelescope / wss_tools

Python tools for JWST Wavefront Sensing Software
https://wss-tools.readthedocs.io
BSD 3-Clause "New" or "Revised" License
11 stars 10 forks source link

Change min SBR for Pupil Imaging and CP to 1500 #83

Closed nflagey-stsci closed 3 years ago

nflagey-stsci commented 3 years ago

Description

This pull request is to update min SBR values in SNRCalc.py for Pupil Imaging and Coarse Phasing (now at 1500 according to Scott Acton)

pllim commented 3 years ago

Thanks! Do you have a new table so we can make sure the documentation at https://wss-tools.readthedocs.io/en/latest/wss_tools/quip/snrcalc.html reflects what is actually happening?

nflagey-stsci commented 3 years ago

The only thing I have is an email from Scott Acton at Ball:

Nick,

Focus Sweep, Segment ID, Image Array 1, GA1, IS1, Coarse MIMF (for forming the array), IA2, GA2, IS2 (for making the initial move) are 500.

Pupil Imaging, CP (1,2,3), coarse MIMF (for making field dependent measurements), IS2 (for the weak lens images), Fine Phasing (1,2,3), MF monitor, PSF focus check, MIMF images are all 1500.

Hope this is useful.

Scott

We cannot disentangle between different parts of an activity, so we'll have to add notes to our procedures for that.

obi-wan76 commented 3 years ago

The original table is in Document No. D36168 Ball No. 2299462 Rev C, Table 3. This document is ITAR but we could update the current table in the help with the new values. Where is the table in the documentation?

pllim commented 3 years ago

It is a image file (probably a screenshot from back in the days): https://github.com/spacetelescope/wss_tools/blob/master/docs/wss_tools/quip/images/sbr_limits_20150519.png

Feel free to remove it and replace with a nice Sphinx RST table. Please only include non-ITAR information.

nflagey-stsci commented 3 years ago

adding a new table to the Docs and changed the RST file so it points to the right PNG file

pllim commented 3 years ago

Can you please delete the old file (sbr_limits_20150519.png) too? Thanks!

pllim commented 3 years ago

p.s. The new PNG is a bit low resolution (at least for me) and hard to read, but as long as you can read it, it is fine by me.

pllim commented 3 years ago

Thanks!