search

spacetelescope / wss_tools

Python tools for JWST Wavefront Sensing Software
https://wss-tools.readthedocs.io
BSD 3-Clause "New" or "Revised" License
11 stars 10 forks source link

98 ginga v4 support #99

Open kulpster85 opened 1 year ago

kulpster85 commented 1 year ago

Description

This pull request is to address ...

Fixes #98

pllim commented 1 year ago

Why is this PR against spacetelescope:98-ginga-v4-support and not spacetelescope:master?

kulpster85 commented 1 year ago

I could go either way. Its more streamlined to go directly into master. I'm not as experienced with the feature branch when dealing with multiple forks of the repo.

pllim commented 1 year ago

I don't remember ever creating the 98-ginga-v4-support branch here. Where did it come from?

kulpster85 commented 1 year ago

I created it and modified your original pull request

pllim commented 1 year ago

Why though?

kulpster85 commented 1 year ago

Thinking more about it I think the rationale is to have a way to checkout the code and do some testing. So if you pushed from your fork then I can commit it to the branch and test after static analysis before merging into master. Does that make sense?

pllim commented 1 year ago

I have no plans to push anything. I was just curious.