search

spacetx / slicedimage

MIT License
7 stars 3 forks source link

Replace scikit-image with tifffile #106

Closed ttung closed 5 years ago

ttung commented 5 years ago

The rationale for this PR is to support more versions of python, as skimage has a pretty narrow range of supported versions (3.5+). However, as it turns out, travis is choking on python <3.5, so maybe there's no point anyway...

Depends on #105

codecov-io commented 5 years ago

Codecov Report

Merging #106 into master will increase coverage by 0.16%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #106      +/-   ##
==========================================
+ Coverage   75.41%   75.57%   +0.16%     
==========================================
  Files          29       29              
  Lines         907      913       +6     
==========================================
+ Hits          684      690       +6     
  Misses        223      223
Impacted Files Coverage Δ
slicedimage/_formats.py 89.36% <100%> (+1.55%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ec0c58c...b3a9c6d. Read the comment docs.

shanaxel42 commented 5 years ago

The rationale for this PR is to support more versions of python, as skimage has a pretty narrow range of supported versions (3.5+). However, as it turns out, travis is choking on python <3.5, so maybe there's no point anyway...

Depends on #105

should I still review this?

ttung commented 5 years ago

should I still review this?

My hunch says yes, because skimage is a very bulky dependency...