search

spacetx / slicedimage

MIT License
7 stars 3 forks source link

Delay S3 resource construction until object requested #111

Closed ttung closed 5 years ago

ttung commented 5 years ago

Constructing a S3 handle takes up memory and time. We retrieve the backend whenever we initialize a tile, but we want to delay the expensive work until the data is requested.

The perf issue is sufficiently bad that we want to do a release, so bumping to 4.0.1.

Test plan: Able to quickly load an experiment where all the tiles are located in th ecloud.

codecov-io commented 5 years ago

Codecov Report

Merging #111 into master will increase coverage by 0.1%. The diff coverage is 93.75%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #111     +/-   ##
=========================================
+ Coverage   75.38%   75.49%   +0.1%     
=========================================
  Files          29       29             
  Lines         902      906      +4     
=========================================
+ Hits          680      684      +4     
  Misses        222      222
Impacted Files Coverage Δ
slicedimage/io/_base.py 58.75% <ø> (ø) :arrow_up:
slicedimage/backends/_s3.py 95.34% <93.75%> (+0.47%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e1c9add...b7a95b9. Read the comment docs.