ttung commented 4 years ago

Switching tiff to using imageio broke 3D tiff operations, as imageio handles 3D images through volread and volwrite. This PR updates tiff handling to use those methods when appropriate.

Test plan: add tests to read and write 2d and 3d tiffs.

codecov-io commented 4 years ago

Codecov Report

Merging #131 into master will increase coverage by 0.02%. The diff coverage is 90.9%.

@@            Coverage Diff             @@
##           master     #131      +/-   ##
==========================================
+ Coverage   79.38%   79.41%   +0.02%     
==========================================
  Files          29       29              
  Lines         946      952       +6     
==========================================
+ Hits          751      756       +5     
- Misses        195      196       +1

Impacted Files	Coverage Δ
slicedimage/_formats.py	`91.66% <90.9%> (-0.93%)`	:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9d487a2...78506a9. Read the comment docs.

ttung commented 4 years ago

@shanaxel42 can you also post commit review this thx.

spacetx / slicedimage

Fix 3D TIFF read/write #131

Codecov Report