search

spacetx / slicedimage

MIT License
7 stars 3 forks source link

[easy] fix typing errors in `can_parse` #135

Closed ttung closed 4 years ago

ttung commented 4 years ago

doc_version should be of instance version.Version

Couple additional build-related issues:

  1. hackery for Windows builds no longer necessary!
  2. running into https://github.com/ahupp/python-magic/issues/213, so pinning python-magic to an earlier version.
codecov-commenter commented 4 years ago

Codecov Report

Merging #135 into master will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #135   +/-   ##
=======================================
  Coverage   79.41%   79.41%           
=======================================
  Files          29       29           
  Lines         952      952           
=======================================
  Hits          756      756           
  Misses        196      196
Impacted Files Coverage Δ
slicedimage/io/_v0_0_0.py 95.65% <100.00%> (ø)
slicedimage/io/_v0_1_0.py 86.02% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 08c9d15...7995150. Read the comment docs.