search

spacetx / slicedimage

MIT License
7 stars 3 forks source link

Version the cache key #39

Closed ttung closed 6 years ago

ttung commented 6 years ago

This will allow us to avoid the corrupt cache entries due to manifests with bogus checksums. This should land after #37 so we won't introduce new corrupt cache entries.

codecov-io commented 6 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (tonytung-cache-protection@e30399e). Click here to learn what that means. The diff coverage is 88.88%.

Impacted file tree graph

@@                     Coverage Diff                      @@
##             tonytung-cache-protection      #39   +/-   ##
============================================================
  Coverage                             ?   79.19%           
============================================================
  Files                                ?       18           
  Lines                                ?      495           
  Branches                             ?        0           
============================================================
  Hits                                 ?      392           
  Misses                               ?      103           
  Partials                             ?        0
Impacted Files Coverage Δ
slicedimage/backends/_caching.py 91.17% <88.88%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e30399e...31b0e71. Read the comment docs.