search

spacetx / slicedimage

MIT License
7 stars 3 forks source link

Remove the seekable parameter. #45

Closed ttung closed 6 years ago

ttung commented 6 years ago

We always want seekable=True. Even though PIL claims to support streaming TIFF decoding, it actually reads into a BytesIO object and decodes from that. Therefore, there is no advantage to maintaining a streaming API.

codecov-io commented 6 years ago

Codecov Report

Merging #45 into master will decrease coverage by 0.3%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #45      +/-   ##
==========================================
- Coverage   80.22%   79.92%   -0.31%     
==========================================
  Files          18       18              
  Lines         526      518       -8     
==========================================
- Hits          422      414       -8     
  Misses        104      104
Impacted Files Coverage Δ
slicedimage/io.py 92.7% <ø> (ø) :arrow_up:
slicedimage/backends/_caching.py 93.33% <100%> (ø) :arrow_up:
slicedimage/backends/_base.py 50% <100%> (ø) :arrow_up:
slicedimage/_formats.py 84.61% <100%> (-1.6%) :arrow_down:
slicedimage/backends/_disk.py 95.23% <100%> (ø) :arrow_up:
slicedimage/backends/_http.py 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update bdadda1...3e3c364. Read the comment docs.