ttung commented 6 years ago

The checksums attached to the tiles are the checksums at the time the tile is loaded. It should not be used to write the tiles.

This should address the issue in this comment

Depends on #50

Test plan: Add a test that writes a TIFF tileset, loads it back up, writes as a NUMPY tileset, and load that back up. Without the change in slicedimage/io.py, it writes the checksum for the TIFF file and the load (and the test) fails. With the change, the test passes.

codecov-io commented 6 years ago

Codecov Report

Merging #51 into master will increase coverage by 0.26%. The diff coverage is 100%.

@@            Coverage Diff            @@
##           master     #51      +/-   ##
=========================================
+ Coverage   80.63%   80.9%   +0.26%     
=========================================
  Files          18      18              
  Lines         532     529       -3     
=========================================
- Hits          429     428       -1     
+ Misses        103     101       -2

Impacted Files	Coverage Δ
slicedimage/io.py	`93.65% <100%> (+0.94%)`	:arrow_up:
slicedimage/_formats.py	`84.61% <100%> (ø)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4d09024...daf8bd1. Read the comment docs.

ttung commented 6 years ago

There are other tests to complement the one written here that will fail if you read something with the wrong checksum, right?

Yes, in each of the backends, there are tests that cover bad checksums.

ttung commented 6 years ago

Updated comment.

spacetx / slicedimage

Always calculate checksums when writing tiles. #51

Codecov Report