search

spacetx / slicedimage

MIT License
7 stars 3 forks source link

Record the tile shape in our data structures if it's not provided. #73

Closed ttung closed 6 years ago

ttung commented 6 years ago

If the tile_shape is not provided by the json file, we should infer it from the actual data. This is a suboptimal data path since it requires a decoding step just to get the shape of the tile, so we warn about it.

Previously, this field was set by _load(), but that was removed in #72.

Test plan: Generate a tileset document, and then strip the shape data from the tiles. Then read it back. The correct tile shapes should be provided, but getting them should trigger a warning.

codecov-io commented 6 years ago

Codecov Report

Merging #73 into master will increase coverage by 0.23%. The diff coverage is 92.3%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #73      +/-   ##
==========================================
+ Coverage   82.49%   82.72%   +0.23%     
==========================================
  Files          18       18              
  Lines         514      521       +7     
==========================================
+ Hits          424      431       +7     
  Misses         90       90
Impacted Files Coverage Δ
slicedimage/_tile.py 97.22% <92.3%> (+0.67%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1fd7546...2eed4f5. Read the comment docs.