search

spacetx / starfish

starfish: unified pipelines for image-based transcriptomics
https://spacetx-starfish.readthedocs.io/en/latest/
MIT License
223 stars 67 forks source link

Update registration module to be compatible with current scikit-image 0.18 and Python 3.9 #1951

Closed mattcai closed 2 years ago

mattcai commented 3 years ago

As scikit-image and Python versions continue to be updated, it is no longer feasible to use scikit-image 0.15.0 to get around . This pull request will make starfish compatible with scikit-image 0.18.*

Closes #1887 and #1950

Also means PR #1946 can be closed

berl commented 3 years ago

@mattcai @kevinyamauchi @neuromusic it looks like the Travis tests are failing here because the test environment is still at python=3.6, so scikit-image is 0.15, which doesn't have the skimage.registration module. Would changing the test to 3.7 (and officially dropping 3.6 support) do the trick?

neuromusic commented 2 years ago

with #1963, this PR is no longer necessary, correct @njmei?

njmei commented 2 years ago

with #1963, this PR is no longer necessary, correct @njmei?

@neuromusic Yes, correct