Closed njmei closed 2 years ago
@mattcai @neuromusic @berl Not sure who has the keys (in terms of reviewing PR and deploying) for this repository anymore, but this PR should address quite a few current issues for this project. The biggest being that the existing Travis CI appears to no longer work (and required custom build agents I think).
My fork of this project appears to be passing almost all tests with the exception of two notebooks which run fine on my local machine but appear to be encountering a permissions issue (maybe from trying to download cloudfront data? Maybe something else?) for DARTFISH and SeqFISH notebooks.
To see test status's on my fork see: https://github.com/njmei/starfish/actions/runs/1349929137
Let me know though if my fork is not showing test status though, since it's possible there might be some repo permissions issue!
@njmei I am super stoked about this.
... and before I can finish my comment, @ttung swoops in and merges it.
thanks @ttung! now we know you're watching....
It's possible that the data is too big to fit on the github actions machines. They are limited to 7GB RAM / 15GB disk, I believe.
Ok, I fixed the notebooks! Hope you're doing well! :)
epic work @njmei!! thanks for the help @ttung :D
Wow, this is amazing! Thank you for the update, @njmei and thanks for merging, @ttung !
This ended up being quite a doozy...
Summary of changes:
For blow by blow please see individual commit messages. I've tried to organize and add as much useful relevant documentation as possible.