search

spaceuptech / space-api-java

Apache License 2.0
5 stars 3 forks source link

Added Batch Request #18

Closed AliabbasMerchant closed 5 years ago

AliabbasMerchant commented 5 years ago

@YourTechBud Done

YourTechBud commented 5 years ago

@AliabbasMerchant you think we should throw an exception for batch.add? Maybe just returb a false if the batch add failed? Im not sure. What do you think?

Also, did you test if it works?

AliabbasMerchant commented 5 years ago

Maybe returning false would be a good idea, but then you would have to exclusively check for the false value every time. An exception would just halt the execution (unless caught), and you can directly write all your multiple statements in a try catch-block.

I haven't tested the batch thing, but assuming that the rest of CRUD works and knowing that the server works, I am hoping that this also works 🤞

AliabbasMerchant commented 5 years ago

@YourTechBud Done