search

spaceuptech / space-api-python

Apache License 2.0
6 stars 3 forks source link

Added Options for LiveQuery #34

Closed AliabbasMerchant closed 5 years ago

AliabbasMerchant commented 5 years ago

@YourTechBud Done

AliabbasMerchant commented 5 years ago

@YourTechBud This is proper. Does not need to be changed.

YourTechBud commented 5 years ago

@AliabbasMerchant you have included the skipInitial and changesOnly in the subscribe function. You need to add a .options() to accept these values

AliabbasMerchant commented 5 years ago

@YourTechBud I do not think a separate options function is required in python. These arguments are optional, and python coders are comfortable using such optional (keyword) arguments.

YourTechBud commented 5 years ago

For consistency lets keep a options functions. Let options take keyword parameters.

AliabbasMerchant commented 5 years ago

@YourTechBud Done

YourTechBud commented 5 years ago

By default, neglect initial should be false. We want to get the result set by default. And can we call it skipInitial and changeOnly

AliabbasMerchant commented 5 years ago

@YourTechBud I have made the latest changes in accordance with the changes on SC

YourTechBud commented 5 years ago

@AliabbasMerchant I've requested some changes in sc. See if it works with that too

AliabbasMerchant commented 5 years ago

Yup. Works! 🚀