spack / spack-infrastructure

Spack Kubernetes instance and services running there (GitLab, CDash, spack.io)
Other
19 stars 20 forks source link

Increase `max_yaml_size_bytes` to 50MB #986

Closed mvandenburgh closed 1 week ago

mvandenburgh commented 1 week ago

See https://spackpm.slack.com/archives/C02N33GM28H/p1730299174926259.

We've encountered a generated pipeline yaml that exceeded the currently set limit of 20MB (https://gitlab.spack.io/spack/spack/-/pipelines/873775). That particular yaml took 20.9MB of memory, which I was able to confirm by patching the staging gitlab instance to report the memory used. (https://gitlab.staging.spack.io/mvandenburgh/spack/-/pipelines/1372)

I'm not sure what the best approach is here; I've bumped up the limit to 50MB, but technically that's a lot more than what we needed in this case. I'm not sure what the implications of a high yaml size limit are, anyone have any thoughts?