search

spack / spack-infrastructure

Spack Kubernetes instance and services running there (GitLab, CDash, spack.io)
Other
19 stars 20 forks source link

sync script: block on "all-prechecks" #993

Closed zackgalbreath closed 9 hours ago

zackgalbreath commented 1 day ago

Update our sync script configuration to not push Spack PR branches until the "all-prechecks" check has succeeded.

scottwittenburg commented 1 day ago

The change looks right to me, based on the names of checks I see. Just need to bump the image version number I think. Or is there more you plan to add?

zackgalbreath commented 1 day ago

The change looks right to me, based on the names of checks I see. Just need to bump the image version number I think. Or is there more you plan to add?

We're not changing the source code of the sync script, just how it gets called from the cron job. So I don't think we need a version bump this time?

mvandenburgh commented 1 day ago

The change looks right to me, based on the names of checks I see. Just need to bump the image version number I think. Or is there more you plan to add?

We're not changing the source code of the sync script, just how it gets called from the cron job. So I don't think we need a version bump this time?

That's correct, no version bump should be needed here