aprokop
commented
2 years ago Can reproduce using the container. I think the following patch may at least partially address it. I'm not sure how to test it without rebuilding everything, though. @eugeneswalker What do I need to change in the spec file to be able to try out the change?
diff --git a/var/spack/repos/builtin/packages/arborx/package.py b/var/spack/repos/builtin/packages/arborx/package.py
index f461679c79..2bf44aa686 100644
--- a/var/spack/repos/builtin/packages/arborx/package.py
+++ b/var/spack/repos/builtin/packages/arborx/package.py
@@ -42,6 +42,7 @@ class Arborx(CMakePackage):
depends_on('cmake@3.12:', type='build')
depends_on('cmake@3.16:', type='build', when='@1.0:')
depends_on('mpi', when='+mpi')
+ depends_on('rocthrust', when='+rocm')
# Standalone Kokkos
depends_on('kokkos@3.1.00:', when='~trilinos')If this does not work, may need to set CMAKE_CXX_COMPILER in addition, something along the lines of
diff --git a/var/spack/repos/builtin/packages/arborx/package.py b/var/spack/repos/builtin/packages/arborx/package.py
index f461679c79..e617b59ee4 100644
--- a/var/spack/repos/builtin/packages/arborx/package.py
+++ b/var/spack/repos/builtin/packages/arborx/package.py
@@ -72,6 +73,9 @@ def cmake_args(self):
# Only Kokkos allows '+cuda' for now
options.append(
'-DCMAKE_CXX_COMPILER=%s' % spec["kokkos"].kokkos_cxx)
+ if '+rocm' in spec:
+ options.append(
+ '-DCMAKE_CXX_COMPILER=%s' % spec["hip"].hipcc)
return options
eugeneswalker
Steps to reproduce the issue
arborx@1.1 +rocmbuild fails at CMake stage using:Tue Feb 8 21:34:38 2022 +0100)Concrete spec: arborx-rocm.spec.json.txt
Concretization:
Quickly reproducible w/ cached dependencies using Docker container image:
ecpe4s/ubuntu20.04-runner-x86_64:2022-02-01Information on your system
Additional information
spack-build-out.txt spack-build-01-cmake-out.txt spack-build-env.txt
@aprokop @masterleinad
General information
spack debug reportand reported the version of Spack/Python/Platformspack maintainers <name-of-the-package>and @mentioned any maintainers