davydden
commented
8 years ago indeed,
$ git diff
diff --git a/var/spack/repos/builtin/packages/openblas/package.py b/var/spack/repos/builtin/packages/openblas/package.py
index 4ec829a..39c49db 100644
--- a/var/spack/repos/builtin/packages/openblas/package.py
+++ b/var/spack/repos/builtin/packages/openblas/package.py
@@ -19,8 +19,8 @@ class Openblas(Package):
def install(self, spec, prefix):
- make_defs = ['CC=%s' % spack_cc,
- 'FC=%s' % spack_fc]
+ make_defs = ['CC=cc',
+ 'FC=f77']
make_targets = ['libs', 'netlib']
@@ -67,4 +67,3 @@ class Openblas(Package):
if '+shared' in self.spec:
self.spec.blas_shared_lib = join_path(libdir, 'libopenblas.%s' % dso_suffix)
self.spec.lapack_shared_lib = self.spec.blas_shared_lib
-fixes missing symbols in Openblas (i have not tried to build Trilinos though). Note, that the build time changes from 1m 37.33s to 3m 42.35s with this change.
@tgamblin do you recall why you changed those arguments in Openblas? My understanding is that CC and F77 point to compiler wrappers, whereas spack_cc and spack_f77 are direct compilers. Why it makes that huge difference here -- i don't know.
alalazo
tgamblin
I gave it a quick try while working on PR and noticed that Trilinos (as of f5a77d39580d215f8d4948b2cbe6c8d47d4fd514) does not build on OSX due to missing
blas/lapacksymbols, see below. I am quite certain that it is related to recent changes inopenblashttps://github.com/LLNL/spack/commit/66bb71534b3ab7eaf7b27743efc0ecf9763e4982 . Possibly usage of thisinstead of
Otherwise I do not see anything that could make a noticeable difference.
Carefull examination confirms the missing symbols in
openblas: current version:previous version:
The issue could be related to compiler wrappers and maybe somehow part of the
openblaswas not actually build. I must say that Trilinos builds on Ubuntu 14.04 with the current version of openblas.This brings us back to the discussion of checking symbols. I think we should take from somewhere (even from the errors below for starters) the list of blas/lapack symbols and do sanity checks within each package that implements blas/lapack. Perhaps also make Travis build modified packages in each PR so that those type of issues appear sooner.
p.s. Actual linking error in Trilinos: