search

spack / spackbot

Spack maintainer bot 🤖
https://spack.github.io/spackbot/
Other
8 stars 12 forks source link

Add core label to changes to any file but var/* #57

Closed haampie closed 3 years ago

haampie commented 3 years ago

It'd be nice to list just "core" PRs

We do something like this in

https://github.com/spack/spack/blob/7f4bf2b2e1263d2c0900c0c15e1f65b15a79fa49/.github/workflows/unit_tests.yaml#L91

tgamblin commented 3 years ago

I like it! @adamjstewart?

adamjstewart commented 3 years ago

LGTM. Should we merge new-package and update-package into a single label?

haampie commented 3 years ago

I kinda like those two separate labels, cause if it says new-package I'm more likely to look at the package name and see if it is reasonable.

All I want is to list non-package prs to see what core changes are upcoming (github allows you to exclude labels, but just clicking a label is easier sometimes)

tgamblin commented 3 years ago

I'll roll out a new spackbot sometime soon -- still debugging style stuff but I will get main in sync with what's deployed and get this in.

haampie commented 3 years ago

thx

haampie commented 3 years ago

could you also add https://github.com/spack/spackbot/pull/56 @tgamblin? i think i will continue to write rerun not re-run.