spack / spackbot

Spack maintainer bot 🤖
https://spack.github.io/spackbot/
Other
8 stars 12 forks source link

Re-run pipelines leaves multiple concurrent pipelines for the same PR #85

Open alalazo opened 1 year ago

alalazo commented 1 year ago

This was reported in Slack by @stephenmsachs

In https://github.com/spack/spack/pull/37627 a few new pipelines are added. As part of CI pipelines were running here:

Then there was a request to spackbot to "re-run pipelines", see https://github.com/spack/spack/pull/37627#issuecomment-1551114406 with subsequent reply at https://github.com/spack/spack/pull/37627#issuecomment-1551114593.

The new pipelines started here:

concurrently with the ones above.

Expected behavior

The behavior I'd expect is that spackbot (or any other mechanism) takes care of canceling previously running pipelines before starting the new ones. This to avoid races when writing to the same buildcache.

Additional notes

The first pipeline was canceled manually on request from the user.

alecbcs commented 1 year ago

@scottwittenburg this sounds like a similar bug to what we all discussed at last week's meeting.