search

spadarian / docblock-python

Atom plugin to insert documentation blocks for python functions
GNU General Public License v2.0
22 stars 9 forks source link

#41: Add view to choose style #42

Closed gonzalezzfelipe closed 4 years ago

gonzalezzfelipe commented 4 years ago

This PR adresses #41.

It adds a command that triggers a view to set the style. After pressing ctrl-alt-s (like ctrl-alt-d but s for style) a pop up, much like the command-pallete shows up with all the options that are present in the templates. It looks like this (at least for me, with material-ui).

image

Here you can search for you choice or go up and down with the keyboard arrows.

image

All in all it looks like this:

out

pd: In case you decide to merge, I recommend a squash because the initial commit is off and doesn't apply.

spadarian commented 4 years ago

Hi @gonzalezzfelipe

Do you mind having a look at #43, #44 and #45? Your PR generated some conflicts with other packages. At first, it was an external package (minimap) but #45 is related to a core package (notifications).

I'm not sure if it is a problem with atom-select-list in general or with your PR.

Cheers!

spadarian commented 3 years ago

This PR was reverted but the maintainers of minimap found a solution (https://github.com/spadarian/docblock-python/issues/43#issuecomment-739129637) in case you want to try again @gonzalezzfelipe