The last update 0.17.3 has conflicts with other packages

[maky-hnou]

• OS: Ubuntu 18.04
• Editor: Atom 1.43.0
• Node: v10.11.0
• docblock-python: 0.17.3
• docblock-python settings: all set to default, none is changed.
• Minimap: 4.29.9
• Minimap setting: all set to default, none is changed.

I opened Atom, everything is working as usual. I got a notification that docblock-python needs to be updated, I updated the package and restarted Atom, but I was surprised that minimap does not work anymore!
I uninstalled minimap and reinstalled it again, uninstalled Atom, removed the configs, and installed atom and minimap all along with docblock-python. However minimap still not working.
I uninstalled docblock-python, minimap is showing again!

I think the last update had messed something, please check it.
Thank you.

[gilbertohasnofb]

Yes, I am also conflicts between this package and minimap, the latter stopped working until I disabled this one here.

[maky-hnou]

@gilbertohasnofb I downgraded docblock-python to the version 0.16.0 to keep using both minimap and docblock-python.
I used this command on Ubuntu: apm install docblock-python@0.16.0

[gilbertohasnofb]

Thank you!

[spadarian]

Thanks for your report. I will look into it during the week.

[spadarian]

There seems to be a problem with minimap and, since it's not currently maintained (the last commit was 17 months ago), I'm not sure how we can fix that.

I think it is possible to fix it by changing line 391 from the function initSubscriptions in the file minimap/lib/main.js:

--- a/lib/main.js
+++ b/lib/main.js
@@ -388,7 +388,7 @@ class Main {
   initSubscriptions () {
     this.subscriptions.add(atom.workspace.observeTextEditors((textEditor) => {
       let minimap = this.minimapForEditor(textEditor)
-      let minimapElement = atom.views.getView(minimap)
+      let minimapElement = this.minimapViewProvider(minimap)

       this.emitter.emit('did-create-minimap', minimap)
       minimapElement.attach()

Do you mind trying that to see if it works in your case?

[maky-hnou]

That worked, thank you!
Please report that bug to minimap

[UziTech]

@spadarian why does that fix this issue?

I'm trying to bring mimap back to life and before I merge https://github.com/atom-minimap/minimap/issues/694 I want to know more about the underlying issue.

[aminya]

I haven't faced this issue. We should first understand it before we apply fixes in minimap.

[spadarian]

@UziTech @aminya I don't remember exactly. https://github.com/spadarian/docblock-python/pull/42 added a style selection menu and, when minimap was present, atom.views.getView would select that menu instead of the minimap (if I remember correctly).

Anyway, I ended up reverting that merge because it had conflicts with other packages and I don't have time to look into that at the moment (it is not an crucial part of docblock-python).

[UziTech]

I see the problem, the atom.views.addViewProvider should check for the correct model or it will return an element every time atom.views.getView() is called by any package.

You can see https://github.com/atom-minimap/minimap/blob/fefc23e747a89c1309fff90a88d5b2492a80a0f7/lib/main.js#L128 as an example

[UziTech]

- atom.views.addViewProvider(() => {
-   return new StyleChooserView(state.StyleChooserViewState).element;
+ atom.views.addViewProvider(StyleChooserView, (model) => {
+   return model.element;
  });

[aminya]

I think making a PR is a good idea! @UziTech

[UziTech]

It sounds like it is not needed anyway since it was removed. I just thought I would put this out there in case they wanted to add it again.

[spadarian]

Thanks guys. I notified the author of the PR in case he wants to try again.