search

spadarian / docblock-python

Atom plugin to insert documentation blocks for python functions
GNU General Public License v2.0
22 stars 9 forks source link

New docblock 0.17 defeats minimap #44

Closed oliver-joos closed 4 years ago

oliver-joos commented 4 years ago

I have installed Atom 1.44.0 and minimap 4.29.9. When I install docblock-python 0.17.3 then minimap won't show up anymore. Toggling minimap off and on again shows an error on developer console, see below!

I does not help to disable suspicious settings of both packages. But if I disable docblock, restart Atom and enable it again, then both packages work as expected and even toggling minimap works without error. So I think there is a problem during startup, maybe some concurrent dependencies?

11:39:25.803 /home/oliver/.atom/packages/minimap/lib/main.js:394 Uncaught TypeError: minimapElement.attach is not a function
    at subscriptions.add.atom.workspace.observeTextEditors (/home/oliver/.atom/packages/minimap/lib/main.js:394)
    at Workspace.observeTextEditors (/usr/share/atom/resources/app/static/<embedded>:11)
    at Main.initSubscriptions (/home/oliver/.atom/packages/minimap/lib/main.js:389)
    at Main.toggle (/home/oliver/.atom/packages/minimap/lib/main.js:184)
    at HTMLElement.minimap:toggle (/home/oliver/.atom/packages/minimap/lib/main.js:98)
    at CommandRegistry.handleCommandEvent (/usr/share/atom/resources/app/static/<embedded>:11)
    at CommandRegistry.dispatch (/usr/share/atom/resources/app/static/<embedded>:11)
    at AtomEnvironment.dispatchApplicationMenuCommand (/usr/share/atom/resources/app/static/<embedded>:1)
    at EventEmitter.t (/usr/share/atom/resources/app/static/<embedded>:1)
    at EventEmitter.emit (events.js:182)
subscriptions.add.atom.workspace.observeTextEditors @ /home/oliver/.atom/packages/minimap/lib/main.js:394
observeTextEditors @ <embedded>:11
initSubscriptions @ /home/oliver/.atom/packages/minimap/lib/main.js:389
toggle @ /home/oliver/.atom/packages/minimap/lib/main.js:184
minimap:toggle @ /home/oliver/.atom/packages/minimap/lib/main.js:98
handleCommandEvent @ <embedded>:11
dispatch @ <embedded>:11
dispatchApplicationMenuCommand @ <embedded>:1
t @ <embedded>:1
emit @ events.js:182
spadarian commented 4 years ago

Hi Oliver,

Can you make sure this is not a duplicate of #43?

oliver-joos commented 4 years ago

This issue IS a duplicate of #43! Your minimap patch there also fixes this issue - thank you!