Potential conflict with notification package

[Tokariew]

Describe the bug Potential conflict with notification package

To Reproduce Steps to reproduce the behavior:

1. Install DocBlock-python package
2. display some notification, open console and run following command

   var n = atom.notifications.addError('sync-settings test', {
   dismissable: true,
   buttons: [{
       text: 'Package settings',
       onDidClick () {
           atom.workspace.open('atom://config/packages/sync-settings')
           n.dismiss()
       },
   }],
   })

3. Atom display error message in console

<embedded>:11 Uncaught TypeError: Failed to execute 'appendChild' on 'Node': parameter 1 is not of type 'Node'.
    at Object.addNotificationView (C:\Users\tokariew\AppData\Local\atom\app-1.44.0\resources\app\static\<embedded>:11:221192)
    at C:\Users\tokariew\AppData\Local\atom\app-1.44.0\resources\app\static\<embedded>:11:217303
    at Function.simpleDispatch (C:\Users\tokariew\AppData\Local\atom\app-1.44.0\resources\app\static\<embedded>:11:1212986)
    at Emitter.emit (C:\Users\tokariew\AppData\Local\atom\app-1.44.0\resources\app\static\<embedded>:11:1214427)
    at NotificationManager.addNotification (C:\Users\tokariew\AppData\Local\atom\app-1.44.0\resources\app\static\<embedded>:11:326934)
    at NotificationManager.addError (C:\Users\tokariew\AppData\Local\atom\app-1.44.0\resources\app\static\<embedded>:11:326712)
    at <anonymous>:1:28

Expected behavior

Not interfere with notification package

More info here

[spadarian]

Thanks for reporting this issue. I think the problem is related to the atom-select-list package.

I already asked the author of that PR to have a look. Since the conflicting code is not essential for docblock-python, I will revert to the previous release if we can not find a fix.

[JSquar]

Just to provide additional information: I observed the same error when using https://atom.io/packages/sync-settings. As soon as I disable docblock-python the notifications show up again.

[spadarian]

Thanks for your report. I have reverted to version v0.16.0. The offending PR was #42 in case someone wants to work on it to address #41