spaghettidba / WorkloadTools

A collection of tools to collect, analyze and replay SQL Server workloads, on premises and in the cloud
MIT License
230 stars 51 forks source link

Improve performance and fix bugs mostly in ReplayConsumer and FileWorkloadListener #137

Closed a-teece closed 9 months ago

a-teece commented 9 months ago
spaghettidba commented 9 months ago

That was quite a ride! Lots of files changed, but I was able to go through all the changes and they totally make sense. Merged! Thank you very much for your contribution!

a-teece commented 9 months ago

Sorry about that. Adding an .editorconfig file to keep every change following the same "style" is super-useful in any project. First thing I would always do in a VisualStudio project these days, even more useful with open source - but the act of turning it on and getting all the current code in-sync is quite the churn.

I'm still working on it all and more warnings/suggestions are still coming out. Visual Studio can unfortunately be slow at evaluating the rules.

spaghettidba commented 9 months ago

Don't be sorry! Phenomenal work, thank you.